[ https://issues.apache.org/jira/browse/HADOOP-14546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16056906#comment-16056906 ]
Hadoop QA commented on HADOOP-14546: ------------------------------------ | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 19m 32s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 3 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 12m 58s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 17s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 12s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 19s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 26s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 13s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 18s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 17s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 17s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 11s{color} | {color:orange} hadoop-tools/hadoop-azure: The patch generated 14 new + 59 unchanged - 0 fixed = 73 total (was 59) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 19s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 36s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 10s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 27s{color} | {color:green} hadoop-azure in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 15s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 38m 41s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:14b5c93 | | JIRA Issue | HADOOP-14546 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12873784/HADOOP-14546.002.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle | | uname | Linux 66590ee04b35 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 1a59847 | | Default Java | 1.8.0_131 | | findbugs | v3.1.0-RC1 | | checkstyle | https://builds.apache.org/job/PreCommit-HADOOP-Build/12584/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-azure.txt | | Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/12584/testReport/ | | modules | C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure | | Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/12584/console | | Powered by | Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > [WASB] Concurrent I/O does not work when secure.mode is enabled. > ---------------------------------------------------------------- > > Key: HADOOP-14546 > URL: https://issues.apache.org/jira/browse/HADOOP-14546 > Project: Hadoop Common > Issue Type: Bug > Components: fs/azure > Affects Versions: 2.9.0, 3.0.0-alpha4 > Reporter: Thomas > Assignee: Thomas > Fix For: 2.9.0, 3.0.0-alpha4 > > Attachments: HADOOP-14546.001.patch, HADOOP-14546.002.patch > > > This change allows the concurrent I/O feature > (fs.azure.io.read.tolerate.concurrent.append = true) to work when secure mode > is enabled (fs.azure.secure.mode = true). > > While running the test TestAzureConcurrentOutOfBandIo.testReadOOBWrites, I > discovered that it fails when fs.azure.secure.mode = true with the error > below: > > com.microsoft.azure.storage.StorageException: The condition specified using > HTTP conditional header(s) is not met. > at > com.microsoft.azure.storage.core.Utility.initIOException(Utility.java:733) > at > com.microsoft.azure.storage.blob.BlobInputStream.dispatchRead(BlobInputStream.java:264) > at > com.microsoft.azure.storage.blob.BlobInputStream.readInternal(BlobInputStream.java:448) > at > com.microsoft.azure.storage.blob.BlobInputStream.read(BlobInputStream.java:420) > at java.io.BufferedInputStream.read1(BufferedInputStream.java:284) > at java.io.BufferedInputStream.read(BufferedInputStream.java:345) > at java.io.DataInputStream.read(DataInputStream.java:149) > at > org.apache.hadoop.fs.azure.TestAzureConcurrentOutOfBandIo.testReadOOBWrites(TestAzureConcurrentOutOfBandIo.java:167) > > There were a couple problems causing this failure: > > 1) AzureNativeFileSystemStore.connectToAzureStorageInSecureMode was disabling > concurrent I/O by setting fs.azure.io.read.tolerate.concurrent.append to > false. > 2) SendRequestIntercept was unnecessarily updating the SAS for the request. > Since this intercept only sets the request header "If-Match: *" to override > the existing recondition, it is not necessary to update the SAS. > > The above issues have been fixed and a new test case has been added so that > testReadOOBWrites now runs both with and without secure mode enabled. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org