[ https://issues.apache.org/jira/browse/HADOOP-14559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057339#comment-16057339 ]
Steve Loughran commented on HADOOP-14559: ----------------------------------------- Closing things is always good due diligence...the codepaths do need to handle failure to setup though. How about we move to a field {{FTPFileSystem ftp}}, with a teardown method calling {{IOUtils.closeStream(ftp)}}. > The used FTPFileSystem in TestFTPFileSystem should be closed in each test > case. > ------------------------------------------------------------------------------- > > Key: HADOOP-14559 > URL: https://issues.apache.org/jira/browse/HADOOP-14559 > Project: Hadoop Common > Issue Type: Improvement > Components: fs, test > Reporter: Hongyuan Li > Assignee: Hongyuan Li > Priority: Minor > > The used FTPFileSystem in TestFTPFileSystem should be closed in each test > case as an improvement. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org