[ https://issues.apache.org/jira/browse/HADOOP-7180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008229#comment-13008229 ]
Hadoop QA commented on HADOOP-7180: ----------------------------------- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12473957/HADOOP-7180-2.patch against trunk revision 1082329. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/311//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/311//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/311//console This message is automatically generated. > Improve CommandFormat > --------------------- > > Key: HADOOP-7180 > URL: https://issues.apache.org/jira/browse/HADOOP-7180 > Project: Hadoop Common > Issue Type: Improvement > Components: fs > Reporter: Daryn Sharp > Assignee: Daryn Sharp > Fix For: 0.23.0 > > Attachments: HADOOP-7180-2.patch, HADOOP-7180.patch > > > CommandFormat currently takes an array and offset for parsing and returns a > list of arguments. It'd be much more convenient to have it process a list > too. It would also be nice to differentiate between too few and too many > args instead of the generic "Illegal number of arguments". Finally, > CommandFormat is completely devoid of tests. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira