[ https://issues.apache.org/jira/browse/HADOOP-14103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16079388#comment-16079388 ]
John Zhuge edited comment on HADOOP-14103 at 7/9/17 5:18 AM: ------------------------------------------------------------- Patch 001: * Add hadoop-tools/hadoop-aws/src/test/resources/contract-test-options.xml which XIncludes auth-keys.xml. * Update filesystem/testing.md and hadoop-aws/testing.md Notes: * Did not update the "ftp" section in filesystem/testing.md * Did not update the "swift" section in filesystem/testing.md. I'd suggest migrate this part to hadoop-openstack's index.md. * Since we are checking in contract-test-options.xml and we have to update "fs.contract.test.fs.s3a" in the file in order to run contract tests, the change may get accidentally committed. Not a credential leak though. was (Author: jzhuge): Patch 001: * Add hadoop-tools/hadoop-aws/src/test/resources/contract-test-options.xml which XIncludes auth-keys.xml. * Update filesystem/testing.md and hadoop-aws/testing.md Notes: * Did not update the "ftp" section in filesystem/testing.md * Did not update the "swift" section in filesystem/testing.md. I'd suggest migrate this part to hadoop-openstack's index.md. * Since we are checking in contract-test-options.xml and we have to update "fs.contract.test.fs.s3a" in the file in order to run contract tests, he change may get accidentally committed. Not a credential leak though. > Sort out hadoop-aws contract-test-options.xml > --------------------------------------------- > > Key: HADOOP-14103 > URL: https://issues.apache.org/jira/browse/HADOOP-14103 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/s3, test > Affects Versions: 2.8.0 > Reporter: Steve Loughran > Assignee: John Zhuge > Priority: Minor > Attachments: HADOOP-14103.001.patch > > > The doc update of HADOOP-14099 has shown that there's confusion about whether > we need a src/test/resources/contract-test-options.xml file. > It's documented as needed, branch-2 has it in .gitignore; trunk doesn't. > I think it's needed for the contract tests, which the S3A test base extends > (And therefore needs). However, we can just put in an SCM managed one and > have it just XInclude auth-keys.xml > I propose: do that, fix up the testing docs to match -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org