[
https://issues.apache.org/jira/browse/HADOOP-14495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107941#comment-16107941
]
Manoj Govindassamy commented on HADOOP-14495:
---------------------------------------------
Looks overall good to me. Thanks for working on this [~eddyxu]. Few questions
below
{{TestLocalFileSystem}}
>> line 753, new BuilderWithSupportedKeys(unsupportedKeys, fileSys, path);
1. The variable naming is little confusing here - unsupportdKeys is passed to
the BuilderWithSupportedKeys ?
2. Can we please extend this test to run #opt() and #must() on the same key,
like "strM", just to cover the corner cases ?
{{FSDataOutputStreamBuilder}},
line 51, the comment can say #opt(key, value) and #must(key, value) to be more
generic.
line 303, like other interfaces, @Nonnull annotation may be needed for the
String value
> Add set options interface to FSDataOutputStreamBuilder
> -------------------------------------------------------
>
> Key: HADOOP-14495
> URL: https://issues.apache.org/jira/browse/HADOOP-14495
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 3.0.0-alpha3
> Reporter: Lei (Eddy) Xu
> Assignee: Lei (Eddy) Xu
> Attachments: HADOOP-14495.00.patch, HADOOP-14495.01.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
