[ 
https://issues.apache.org/jira/browse/HADOOP-14398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lei (Eddy) Xu updated HADOOP-14398:
-----------------------------------
    Attachment: HADOOP-14398.01.patch

Thanks for the detailed review, [~fabbri]!

bq. I think you mean the Filesystem instance; some filesystems don't modify the 
underlying FS until close(). 

Good catch. Fixed.

bq. What is the difference in behavior / semantics between opt() and must()?
bq. What is the conflict resolution behavior if there is a builder method (e.g. 
.someOption()) that conflicts with a Configuration option set via opt() or 
must()? ("undefined" is a possibility, but should be specified at least?).

Done. Specified as "undefined" for now. If later on, the specific filesystem 
builder implementation needs to revise this, we can file follow on JIRA.

bq. Seems like the invalid settings are:

This is aligned with {{CreateFlag.java}}. 

Thanks!


> Modify documents for the FileSystem Builder API
> -----------------------------------------------
>
>                 Key: HADOOP-14398
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14398
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs
>    Affects Versions: 3.0.0-alpha3
>            Reporter: Lei (Eddy) Xu
>            Assignee: Lei (Eddy) Xu
>              Labels: docuentation
>         Attachments: HADOOP-14398.00.patch, HADOOP-14398.01.patch
>
>
> After finishes the API, we should update the document to describe the 
> interface, capability and contract which the APIs hold. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to