[ 
https://issues.apache.org/jira/browse/HADOOP-14743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119321#comment-16119321
 ] 

Kai Zheng commented on HADOOP-14743:
------------------------------------

+1 for the nice change. Thanks!

> CompositeGroupsMapping should not swallow exceptions
> ----------------------------------------------------
>
>                 Key: HADOOP-14743
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14743
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 2.5.0
>            Reporter: Wei-Chiu Chuang
>            Assignee: Wei-Chiu Chuang
>         Attachments: HADOOP-14743.001.patch, HADOOP-14743.002.patch
>
>
> {code:title=CompositeGroupsMapping#getGroups}
>    for (GroupMappingServiceProvider provider : providersList) {
>       try {
>         groups = provider.getGroups(user);
>       } catch (Exception e) {
>         //LOG.warn("Exception trying to get groups for user " + user, e);     
>  
>       }        
>       if (groups != null && ! groups.isEmpty()) {
>         groupSet.addAll(groups);
>         if (!combined) break;
>       }
>     }
> {code}
> If anything fails inside the underlying groups mapping service provider, 
> there's no way to tell what went wrong.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to