[ https://issues.apache.org/jira/browse/HADOOP-14769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127831#comment-16127831 ]
Esfandiar Manii commented on HADOOP-14769: ------------------------------------------ +1 with few comments: AzureNativeFileSystemStore.java L2503-2505: Not sure how much we want to invest on this but there are many of this code everywhere, I wish there was only one method doing this. NativeAzureFileSystem.java L2099-2108: instead of nested ifs please rewrite it to be like (for better code clarity): if (!store.delete(path)) { return false; } if (isDir) { } else { } return true; TestFileSystemOperationsWithThreads.java L592-594: nit: Please fix indentation > WASB: delete recursive should not fail if a file is deleted > ----------------------------------------------------------- > > Key: HADOOP-14769 > URL: https://issues.apache.org/jira/browse/HADOOP-14769 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/azure > Reporter: Thomas Marquardt > Assignee: Thomas Marquardt > Attachments: HADOOP-14769-001.patch > > > FileSystem.delete(Path path) and delete(Path path, boolean recursive) return > false if the path does not exist. The WASB implementation of recursive > delete currently fails if one of the entries is deleted by an external agent > while a recursive delete is in progress. For example, if you try to delete > all of the files in a directory, which can be a very long process, and one of > the files contained within is deleted by an external agent, the recursive > directory delete operation will fail if it tries to delete that file and > discovers that it does not exist. This is not desirable. A recursive > directory delete operation should succeeed if the directory initially exists > and when the operation completes, the directory and all of its entries do not > exist. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org