[ 
https://issues.apache.org/jira/browse/HADOOP-14705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16129874#comment-16129874
 ] 

Xiao Chen commented on HADOOP-14705:
------------------------------------

Sorry figured I omitted the comment about stopwatch.
bq. Also, does it return time in milliseconds? Can you add the time unit into 
log message as well?
>From recent debugging experience, I think it makes sense to add this message 
>to info level, so we can easily find how the underlying keyprovider performed 
>in the hind sight.
The stopwatch used is a {{com.google.common.base.Stopwatch}}, and can 
conveniently handle units dynamically in toString. A sample log reads this:
bq. ... reencryptEncryptedKeys 1000 keys for key k1 took 51.64 ms

> Add batched reencryptEncryptedKey interface to KMS
> --------------------------------------------------
>
>                 Key: HADOOP-14705
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14705
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: kms
>            Reporter: Xiao Chen
>            Assignee: Xiao Chen
>         Attachments: HADOOP-14705.01.patch, HADOOP-14705.02.patch, 
> HADOOP-14705.03.patch, HADOOP-14705.04.patch, HADOOP-14705.05.patch
>
>
> HADOOP-13827 already enabled the KMS to re-encrypt a {{EncryptedKeyVersion}}.
> As the performance results of HDFS-10899 turns out, communication overhead 
> with the KMS occupies the majority of the time. So this jira proposes to add 
> a batched interface to re-encrypt multiple EDEKs in 1 call.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to