[ 
https://issues.apache.org/jira/browse/HADOOP-7207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019564#comment-13019564
 ] 

Boris Shkolnik commented on HADOOP-7207:
----------------------------------------

+1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 3 new or 
modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning 
messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs 
(version 1.3.7) warnings.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
     [exec] 
     [exec]     +1 system test framework.  The patch passed system test 
framework compile.
     [exec] 


> fs member of FSShell is not really needed
> -----------------------------------------
>
>                 Key: HADOOP-7207
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7207
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Boris Shkolnik
>            Assignee: Boris Shkolnik
>         Attachments: HADOOP-7207-2.patch, HADOOP-7207-3.patch
>
>
> FileSystem object should be created on demand when needed in FSShell, instead 
> of always creating one that connects to the default FileSystem.
> It will also solve a problem of connecting to non-existant/non-functional 
> default, when it is not really needed for this run.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to