[
https://issues.apache.org/jira/browse/HADOOP-12672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16189326#comment-16189326
]
Yufei Gu commented on HADOOP-12672:
-----------------------------------
Thanks [~iwasakims]. I think that *zero means infinity* is counter-intuitive
and error-prone through Java lib does that as well. Zero could be considered as
a valid timeout value, while negative one isn't. It's kinda of like the debut
of if zero is the natural number. If we use zero to represent infinity, which
number could be used to represent no timeout?
Both Client#getTimeout and Client#geRpcTimeout are not used really, only a unit
test calls that. They probably are fine to change.
> RPC timeout should not override IPC ping interval
> -------------------------------------------------
>
> Key: HADOOP-12672
> URL: https://issues.apache.org/jira/browse/HADOOP-12672
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 2.8.0, 2.7.3, 2.6.4
> Reporter: Masatake Iwasaki
> Assignee: Masatake Iwasaki
> Fix For: 2.8.0, 3.0.0-alpha1
>
> Attachments: HADOOP-12672.001.patch, HADOOP-12672.002.patch,
> HADOOP-12672.003.patch, HADOOP-12672.004.patch, HADOOP-12672.005.patch,
> HADOOP-12672.006.patch
>
>
> Currently if the value of ipc.client.rpc-timeout.ms is greater than 0, the
> timeout overrides the ipc.ping.interval and client will throw exception
> instead of sending ping when the interval is passed. RPC timeout should work
> without effectively disabling IPC ping.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
