[ https://issues.apache.org/jira/browse/HADOOP-5943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16194654#comment-16194654 ]
Andras Bokor commented on HADOOP-5943: -------------------------------------- I agree: * The current logic does not meet with the Java 7 pattern. In Java 7 try-catch-resources are preferred. * Misleading. I found some misusages that may cause double calls in InputStreams. Please see HADOOP-14691 for example. > IOUtils#copyBytes methods should not close streams that are passed in as > parameters > ----------------------------------------------------------------------------------- > > Key: HADOOP-5943 > URL: https://issues.apache.org/jira/browse/HADOOP-5943 > Project: Hadoop Common > Issue Type: Bug > Components: io > Reporter: Hairong Kuang > Assignee: Andras Bokor > Attachments: HADOOP-5943.01.patch > > > The following methods in IOUtils close the streams that are passed in as > parameters. Calling these methods can easily trigger findbug OBL: Method may > fail to clean up stream or resource (OBL_UNSATISFIED_OBLIGATION). A good > practice should be to close a stream in the same method where the stream is > opened. > public static void copyBytes(InputStream in, OutputStream out, int buffSize, > boolean close) > public static void copyBytes(InputStream in, OutputStream out, Configuration > conf, boolean close) > These methods should be deprecated. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org