[ https://issues.apache.org/jira/browse/HADOOP-14944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xiao Chen updated HADOOP-14944: ------------------------------- Attachment: HADOOP-14944.03.patch Didn't see you already reviewed when posting last patch. Thanks for reviewing, John! Patch 3 addressed all comments except the first one, for the following reasons: - Although the {{KMSWebApp}} implements {{ServletContextListener}}, it's currently not just a servlet class. It contains the audits, acls and the underlying provider details. - Currently it has jmx reporter. If I'm just looking for where the jmx for gc (for example) is reported, my search for jmx will land in there first. - Backporting to branch-2 will be easier, since branch-2 doesn't have {{KMSWebServer}}, and it's likely this code will go to either {{KMSWebApp}} or {{KMS}} - the latter seems to be more of a rest end point and less fit for the metrics. > Add JvmMetrics to KMS > --------------------- > > Key: HADOOP-14944 > URL: https://issues.apache.org/jira/browse/HADOOP-14944 > Project: Hadoop Common > Issue Type: Improvement > Components: kms > Affects Versions: 2.6.0 > Reporter: Xiao Chen > Assignee: Xiao Chen > Attachments: HADOOP-14944.01.patch, HADOOP-14944.02.patch, > HADOOP-14944.03.patch > > > Let's make KMS to use {{JvmMetrics}} to report aggregated statistics about > heap / GC etc. > This will make statistics monitoring easier, and compatible across the > tomcat-based (branch-2) KMS and the jetty-based (branch-3) KMS. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org