[
https://issues.apache.org/jira/browse/HADOOP-14971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16233627#comment-16233627
]
Aaron Fabbri commented on HADOOP-14971:
---------------------------------------
looking at latest patch (via github actually, so I can easily see the new
commits separately)
- Thanks for writing up the security stuff we talked about.
- Good idea changing committer temp dir to be relative and documenting that.
Thanks for writing a test case too.
- Thanks for bringing back the separate s3a / sdk retry maximums. Makes me
feel safer. :-)
- Class renames and constants refactoring looks fine.
This looks good to me. I just need to finish testing this latest patch.
Running integration tests now. (BTW a truck took out my internet Friday after
we chatted [~ste...@apache.org] so I've been working over a cellular modem.
Supposed to be fixed tomorrow).
> Merge S3A committers into trunk
> -------------------------------
>
> Key: HADOOP-14971
> URL: https://issues.apache.org/jira/browse/HADOOP-14971
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.0.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Attachments: HADOOP-13786-040.patch, HADOOP-13786-041.patch
>
>
> Merge the HADOOP-13786 committer into trunk. This branch is being set up as a
> github PR for review there & to keep it out the mailboxes of the watchers on
> the main JIRA
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
