[
https://issues.apache.org/jira/browse/HADOOP-15085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293285#comment-16293285
]
Jason Lowe commented on HADOOP-15085:
-------------------------------------
Thanks for providing a branch-2 patch!
The MiniKMS change in the branch-2 patch doesn't seem appropriate, since there
isn't any use of IOUtils.cleanup or IOUtils.closeStream in the branch-2 version
of MiniKMS. As it is now, it's like this patch incorporates the MiniKMS
changes from HADOOP-12615 as well.
> Output streams closed with IOUtils suppressing write errors
> -----------------------------------------------------------
>
> Key: HADOOP-15085
> URL: https://issues.apache.org/jira/browse/HADOOP-15085
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Jason Lowe
> Assignee: Jim Brennan
> Fix For: 3.1.0, 3.0.1
>
> Attachments: HADOOP-15085-branch-2.001.patch,
> HADOOP-15085-branch-2.002.patch, HADOOP-15085.001.patch,
> HADOOP-15085.002.patch, HADOOP-15085.003.patch, HADOOP-15085.004.patch,
> HADOOP-15085.005.patch
>
>
> There are a few places in hadoop-common that are closing an output stream
> with IOUtils.cleanupWithLogger like this:
> {code}
> try {
> ...write to outStream...
> } finally {
> IOUtils.cleanupWithLogger(LOG, outStream);
> }
> {code}
> This suppresses any IOException that occurs during the close() method which
> could lead to partial/corrupted output without throwing a corresponding
> exception. The code should either use try-with-resources or explicitly close
> the stream within the try block so the exception thrown during close() is
> properly propagated as exceptions during write operations are.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
