[
https://issues.apache.org/jira/browse/HADOOP-15027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311155#comment-16311155
]
SammiChen commented on HADOOP-15027:
------------------------------------
Thanks [~wujinhu] for working on it. some comments,
1. DEFAULT_MAX_TOTAL_TASKS = 128; the naming pattern is not consistent
with others. Put the default as suffix.
2. take care of all the checkstyle issues
3. {quote}
store.close();
boundedThreadPool.shutdown();
{quote}
will store.close throw any exception so that boundedThreadPool.shutdown
be skipped?
4. "fs.oss.max.total.tasks" is the maximum of waiting queue length, right?
5. It seems fsDataInputStream.seek() is missed between the two asserts.
{quote}
assertTrue("expected position at:" + 0 + ", but got:"
+ fsDataInputStream.getPos(), fsDataInputStream.getPos() == 0);
assertTrue("expected position at:" + 1048576 + ", but got:"
+ in.getExpectNextPos(),
in.getExpectNextPos() == 1048576);
{quote}
6. Can we add more test cases to cover the failure cases, to verify the error
handling functions correctly.
> AliyunOSS: Support multi-thread pre-read to improve read from Hadoop to
> Aliyun OSS performance
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-15027
> URL: https://issues.apache.org/jira/browse/HADOOP-15027
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/oss
> Affects Versions: 3.0.0
> Reporter: wujinhu
> Assignee: wujinhu
> Attachments: HADOOP-15027.001.patch, HADOOP-15027.002.patch,
> HADOOP-15027.003.patch, HADOOP-15027.004.patch, HADOOP-15027.005.patch,
> HADOOP-15027.006.patch, HADOOP-15027.007.patch
>
>
> Currently, AliyunOSSInputStream uses single thread to read data from
> AliyunOSS, so we can do some refactoring by using multi-thread pre-read to
> improve read performance.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
