[
https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353044#comment-16353044
]
Andras Bokor commented on HADOOP-10571:
---------------------------------------
{quote}
h4. LocalFileSystem
L142 we could move to making {{p}} another arg
{quote}
LocalFilesystem still uses commons logging and a comment says
{quote}This log is widely used in the org.apache.hadoop.fs code and tests, so
must be considered something to only be changed with care.{quote}
Other comments are addressed.
> Use Log.*(Object, Throwable) overload to log exceptions
> -------------------------------------------------------
>
> Key: HADOOP-10571
> URL: https://issues.apache.org/jira/browse/HADOOP-10571
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.4.0
> Reporter: Arpit Agarwal
> Assignee: Andras Bokor
> Priority: Major
> Attachments: HADOOP-10571.01.patch, HADOOP-10571.01.patch,
> HADOOP-10571.02.patch, HADOOP-10571.03.patch, HADOOP-10571.04.patch,
> HADOOP-10571.05.patch
>
>
> When logging an exception, we often convert the exception to string or call
> {{.getMessage}}. Instead we can use the log method overloads which take
> {{Throwable}} as a parameter.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
