[ https://issues.apache.org/jira/browse/HADOOP-14445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397866#comment-16397866 ]
Xiao Chen edited comment on HADOOP-14445 at 3/13/18 11:48 PM: -------------------------------------------------------------- Thanks for the review [~jojochuang], good comments! Also looking forward to [~daryn]'s review. Appreciate the review cycles. bq. Why was KerberosConfiguration removed in the patch? I was confused when adding tests and found that it's not used anywhere. Added it back, can have the removal done in a separate jira for cleanness. bq. close the KeyProviders in TestKMS... in the initial test code ... Good catch. I think this was missed in day 0 tests. Handled in this patch for review convenience, but created HADOOP-15313 for cleanness.. All other comments are addressed in, and good catch on the duplicate test method. Indeed client versions are hard to manage - the config is only a way to not duplicate tokens once we're sure everything is upgraded. I added more text into core-default.xml to explain, and will add similar lines to release notes once this is in. Didn't add to documentation because I fear this would confuse average users when they see that from documentation... was (Author: xiaochen): Thanks for the review [~jojochuang], good comments! Also looking forward to [~daryn]'s review. Appreciate the review cycles. bq. Why was KerberosConfiguration removed in the patch? I was confused when adding tests and found that it's not used anywhere. Added it back, can have the removal done in a separate jira for cleanness. bq. close the KeyProviders in TestKMS... in the initial test code ... Good catch. I think this was missed in day 0 tests. Handled in this patch for review convenience, but created HADOOP-13513 for cleanness.. All other comments are addressed in, and good catch on the duplicate test method. Indeed client versions are hard to manage - the config is only a way to not duplicate tokens once we're sure everything is upgraded. I added more text into core-default.xml to explain, and will add similar lines to release notes once this is in. Didn't add to documentation because I fear this would confuse average users when they see that from documentation... > Delegation tokens are not shared between KMS instances > ------------------------------------------------------ > > Key: HADOOP-14445 > URL: https://issues.apache.org/jira/browse/HADOOP-14445 > Project: Hadoop Common > Issue Type: Bug > Components: kms > Affects Versions: 2.8.0, 3.0.0-alpha1 > Environment: CDH5.7.4, Kerberized, SSL, KMS-HA, at rest encryption > Reporter: Wei-Chiu Chuang > Assignee: Xiao Chen > Priority: Major > Attachments: HADOOP-14445-branch-2.8.002.patch, > HADOOP-14445-branch-2.8.patch, HADOOP-14445.002.patch, > HADOOP-14445.003.patch, HADOOP-14445.004.patch, HADOOP-14445.05.patch, > HADOOP-14445.06.patch > > > As discovered in HADOOP-14441, KMS HA using LoadBalancingKMSClientProvider do > not share delegation tokens. (a client uses KMS address/port as the key for > delegation token) > {code:title=DelegationTokenAuthenticatedURL#openConnection} > if (!creds.getAllTokens().isEmpty()) { > InetSocketAddress serviceAddr = new InetSocketAddress(url.getHost(), > url.getPort()); > Text service = SecurityUtil.buildTokenService(serviceAddr); > dToken = creds.getToken(service); > {code} > But KMS doc states: > {quote} > Delegation Tokens > Similar to HTTP authentication, KMS uses Hadoop Authentication for delegation > tokens too. > Under HA, A KMS instance must verify the delegation token given by another > KMS instance, by checking the shared secret used to sign the delegation > token. To do this, all KMS instances must be able to retrieve the shared > secret from ZooKeeper. > {quote} > We should either update the KMS documentation, or fix this code to share > delegation tokens. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org