[ https://issues.apache.org/jira/browse/HADOOP-14067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16341661#comment-16341661 ]
Bharat Viswanadham edited comment on HADOOP-14067 at 3/19/18 10:21 PM: ----------------------------------------------------------------------- [~thejas] The patch is having checkstyle issues and javadoc errors. Other than that +1 from me. was (Author: bharatviswa): The patch is having checkstyle issues and javadoc errors. Other than that +1 from me. > VersionInfo should load version-info.properties from its own classloader > ------------------------------------------------------------------------ > > Key: HADOOP-14067 > URL: https://issues.apache.org/jira/browse/HADOOP-14067 > Project: Hadoop Common > Issue Type: Bug > Components: common > Affects Versions: 2.8.3, 3.0.0 > Reporter: Thejas M Nair > Assignee: Thejas M Nair > Priority: Major > Attachments: HADOOP-14067.01.patch > > > org.apache.hadoop.util.VersionInfo loads the version-info.properties file via > the current thread classloader. > However, in case of applications that are using hadoop classes dynamically > (eg jdbc based tools such as SQuirreL SQL) the current thread might not be > the one that loaded the hadoop classes including VersionInfo, and it would > fail to fine the properties file. > The right place to look for the properties file is in the classloader of > VersionInfo class, as right version is the one that is associated with rest > of the loaded hadoop classes, and not necessarily the one in current thread > classloader. > Created a related jira - HADOOP-14066 to make methods to get version via > VersionInfo a public api. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org