[
https://issues.apache.org/jira/browse/HADOOP-15253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16407251#comment-16407251
]
Xiaoyu Yao commented on HADOOP-15253:
-------------------------------------
[~Tao Jie] and [~shv] , sorry I'm late in the review. The patch 003 looks good
to me. I just have one NIT if it has not been committed.
TestRefreshCallQueue.java
Line 148/168: It will be better if we could replace the hard-coded 10 to
{color:#000080}{code}{color}
{color:#000080}int {color}{color:#000000}serviceHandlerCount= {color}
{color:#000000}conf.getInt({color}{color:#660e7a}DFS_NAMENODE_SERVICE_HANDLER_COUNT_KEY{color}{color:#000000},{color}{color:#660e7a}DFS_NAMENODE_SERVICE_HANDLER_COUNT_DEFAULT{color}{color:#000000});{color}
{code}
> Should update maxQueueSize when refresh call queue
> --------------------------------------------------
>
> Key: HADOOP-15253
> URL: https://issues.apache.org/jira/browse/HADOOP-15253
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 2.8.2
> Reporter: Tao Jie
> Assignee: Tao Jie
> Priority: Minor
> Attachments: HADOOP-15253.001.patch, HADOOP-15253.002.patch,
> HADOOP-15253.003.patch
>
>
> When calling {{dfsadmin -refreshCallQueue}} to update CallQueue instance,
> {{maxQueueSize}} should also be updated.
> In case of changing CallQueue instance to FairCallQueue, the length of each
> queue in FairCallQueue would be 1/priorityLevels of original length of
> DefaultCallQueue. So it would be helpful for us to set the length of
> callqueue to a proper value.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
