[ 
https://issues.apache.org/jira/browse/HADOOP-15313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16412170#comment-16412170
 ] 

Xiao Chen commented on HADOOP-15313:
------------------------------------

Thanks for the review [~jojochuang], good catch. Handled createKMSCP, and 
removed the explicit close on 502 / 520.

We still need the explicit close at 475 / 2197 to verify the close method 
itself doesn't leak threads, so left these 2 as-is. (Added a comment to 475 to 
make this clearer)

> TestKMS should close providers
> ------------------------------
>
>                 Key: HADOOP-15313
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15313
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: kms, test
>            Reporter: Xiao Chen
>            Assignee: Xiao Chen
>            Priority: Major
>         Attachments: HADOOP-15313.01.patch, HADOOP-15313.02.patch, 
> HADOOP-15313.03.patch
>
>
> During the review of HADOOP-14445, [~jojochuang] found that we key providers 
> are not closed in tests. Details in [this 
> comment|https://issues.apache.org/jira/browse/HADOOP-14445?focusedCommentId=16397824&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16397824].
> We should investigate and handle that in all related tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to