[
https://issues.apache.org/jira/browse/HADOOP-15344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427616#comment-16427616
]
Xiao Chen commented on HADOOP-15344:
------------------------------------
Makes sense. IMO that falls to API semantics - close should still throw. It's a
broader API and we should follow the general close behavior (e.g.
java.io.IOException.Closeable)
If a caller wants to swallow and log the close exception, they can do tat. In
this case, I think KMSTokenRenewer should log.error the close.
> LoadBalancingKMSClientProvider#close should not swallow exceptions
> ------------------------------------------------------------------
>
> Key: HADOOP-15344
> URL: https://issues.apache.org/jira/browse/HADOOP-15344
> Project: Hadoop Common
> Issue Type: Bug
> Components: kms
> Reporter: Xiao Chen
> Assignee: fang zhenyi
> Priority: Minor
> Attachments: HADOOP-15344.001.patch
>
>
> As [~shahrs87]'s comment on HADOOP-14445 says:
> {quote}
> LoadBalancingKMSCP never throws IOException back. It just swallows all the
> IOException and just logs it.
> ...
> Maybe we might want to return MultipleIOException from
> LoadBalancingKMSCP#close.
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
