[ https://issues.apache.org/jira/browse/HADOOP-14756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430890#comment-16430890 ]
Gabor Bota edited comment on HADOOP-14756 at 4/9/18 5:14 PM: ------------------------------------------------------------- Hi [~fabbri], [~ste...@apache.org], I've started progress on this issue, and I have some questions about it. #3: * In case the "isNew" flag implementation is needed I assume it would be an additional attribute in dynamodb table for the entries. Is this correct? * Right now there is a comment about it in org/apache/hadoop/fs/s3a/s3guard/LocalMetadataStore.java:246 - Is it still valid? * As [~fabbri] said, as the DirListingMetadata supports the isAuthoritative flag there is no need for this change. If there's no need for it, could it be removed from the description? was (Author: gabor.bota): Hi [~fabbri], [~ste...@apache.org], I've started progress on this issue, and I have some questions about it. #3: * In case the "isNew" flag implementation is needed I assume it would be an additional attribute in dynamodb table for the entries. Is this correct? * Right now there is a comment about it in org/apache/hadoop/fs/s3a/s3guard/LocalMetadataStore.java:246 - Is it still valid? * As [~fabbri] said, as the DirListingMetadata supports the isAuthoritative flag there is no need for this change. Could it be removed from the description? > S3Guard: expose capability query in MetadataStore and add tests of > authoritative mode > ------------------------------------------------------------------------------------- > > Key: HADOOP-14756 > URL: https://issues.apache.org/jira/browse/HADOOP-14756 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/s3 > Affects Versions: 3.0.0-beta1 > Reporter: Steve Loughran > Assignee: Gabor Bota > Priority: Major > > {{MetadataStoreTestBase.testListChildren}} would be improved with the ability > to query the features offered by the store, and the outcome of {{put()}}, so > probe the correctness of the authoritative mode > # Add predicate to MetadataStore interface > {{supportsAuthoritativeDirectories()}} or similar > # If #1 is true, assert that directory is fully cached after changes > # Add "isNew" flag to MetadataStore.put(DirListingMetadata); use to verify > when changes are made -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org