[
https://issues.apache.org/jira/browse/HADOOP-15465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478985#comment-16478985
]
Steve Loughran commented on HADOOP-15465:
-----------------------------------------
FileUtil
Does this do the right thing regarding failure to symlink? That is: do all the
callers check the return code and react to a failure, or do they expect
exceptions to be thrown if there's a problem? With this patch all problems but
one raise exceptions (good), but symlink on window failures downgraded to
logging a warning. Should those failures be rethrown?
Shell
* can you revert the reorder of imports there. I know the existing one is
flawed, but reordering imports invariably creates merge and backport pain. Best
to leave alone, even when the nominal ordering rules are broken.
* L301. Can you add a para in the javadocs saying "Deprecated and likely to be
deleted in the near future. Pleas use FileUtil.symlink()". Helps users to
migrate.
MiniYarnCluster
* checkstyle: delete the now-unused ShellExecutor import
* L211: pass in the caught exception to the YarnException constructor, so its
stack trace is retained. The original code did this.
> Deprecate WinUtils#Symlinks by using native java code
> -----------------------------------------------------
>
> Key: HADOOP-15465
> URL: https://issues.apache.org/jira/browse/HADOOP-15465
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Íñigo Goiri
> Assignee: Giovanni Matteo Fumarola
> Priority: Major
> Attachments: HADOOP-15465.v0.patch, HADOOP-15465.v0.proto.patch,
> HADOOP-15465.v1.patch, HADOOP-15465.v2.patch
>
>
> Hadoop uses the shell to create symbolic links. Now that Hadoop relies on
> Java 7+, we can deprecate all the shell code and rely on the Java APIs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
