[ https://issues.apache.org/jira/browse/HADOOP-14918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495944#comment-16495944 ]
Aaron Fabbri commented on HADOOP-14918: --------------------------------------- Shout if you need any help testing this [~gabor.bota]. A couple of thoughts about moving the two MetadataStore destroy tests out of the way. # I do not think we should have the test create / destroy a test table for the *regular* test cases. Many users (me included) want to use an existing table for tests. If a user wants the test to auto-create a table, they can configure the DDB auto create option in their hadoop config. # For the *destructive* tests, i.e. {{AbstractS3GuardToolTestBase#testDestroyNoBucket}} and {{ITestS3GuardToolDynamoDB#testDynamoDBInitDestroyCycle}} we could just make ITestS3GuardToolDynamoDB execute in the serial (non-parallel) phase, I think. Also, as we said above, these only run if the contract test options have a "dynamodb destructive test table" configured. For these two tests, yes the test should create and destroy its own table. > remove the Local Dynamo DB test option > -------------------------------------- > > Key: HADOOP-14918 > URL: https://issues.apache.org/jira/browse/HADOOP-14918 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/s3 > Affects Versions: 2.9.0, 3.0.0 > Reporter: Steve Loughran > Assignee: Gabor Bota > Priority: Major > Attachments: HADOOP-14918-001.patch, HADOOP-14918-002.patch, > HADOOP-14918-003.patch, HADOOP-14918-004.patch > > > I'm going to propose cutting out the localdynamo test option for s3guard > * the local DDB JAR is unmaintained/lags the SDK We work with...eventually > there'll be differences in API. > * as the local dynamo DB is unshaded. it complicates classpath setup for the > build. Remove it and there's no need to worry about versions of anything > other than the shaded AWS > * it complicates test runs. Now we need to test for both localdynamo *and* > real dynamo > * but we can't ignore real dynamo, because that's the one which matters > While the local option promises to reduce test costs, really, it's just > adding complexity. If you are testing with s3guard, you need to have a real > table to test against., And with the exception of those people testing s3a > against non-AWS, consistent endpoints, everyone should be testing with > S3Guard. > -Straightforward to remove.- -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org