[
https://issues.apache.org/jira/browse/HADOOP-7322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038908#comment-13038908
]
Matt Foley commented on HADOOP-7322:
------------------------------------
Thanks, Bharath. Unfortunately I have one more item. Looking more at
testlistFiles(), there are many calls that could cause an IOException, but only
the last one should be an allowed IOException. Therefore, I think we have to
remove the "expected=IOException.class" from the @Test annotation, and instead
use the idiom:
{code}
try {
files = FileUtil.listFiles(newDir);
fail("IOException expected on listFiles() for non-existent dir " +
newDir.getString());
} catch (IOException ioe) {
//expected
}
{code}
> Adding a util method in FileUtil for directory listing
> ------------------------------------------------------
>
> Key: HADOOP-7322
> URL: https://issues.apache.org/jira/browse/HADOOP-7322
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Bharath Mundlapudi
> Assignee: Bharath Mundlapudi
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: HADOOP-7322-1.patch, HADOOP-7322-2.patch
>
>
> While testing Disk Fail Inplace, we encountered lots of NPE from
> Dir.listFiles API. This API can return null when Dir is not directory or disk
> is bad. I am proposing to have a File Util which can be used consistently
> across to deal with disk issues. This util api will do the following:
> 1. When error happens it will throw IOException
> 2. Else it will return empty list or list of files.
> Signature:
> File[] FileUtil.listFiles(File dir) throws IOException {}
> This way we no need to write wrapper code every where. Also, API is
> consistent with the signature.
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
