[ https://issues.apache.org/jira/browse/HADOOP-15546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated HADOOP-15546: ------------------------------------ Description: Followup on HADOOP-15540 with some initial review tuning h2. Tuning * ordering of imports * rely on azure-auth-keys.xml to store credentials (change imports, docs,.gitignore) * log4j -> info * add a "." to the first sentence of all the javadocs I noticed. * remove @Public annotations except for some constants (which includes some commitment to maintain them). * move the AbstractFS declarations out of the src/test/resources XML file into core-default.xml for all to use * other IDE-suggested tweaks h2. Testing Review the tests, move to ContractTestUtil assertions, make more consistent to contract test setup, and general work to make the tests work well over slower links, document, etc. was: Followup on HADOOP-15540 with some initial review tuning * ordering of imports * rely on azure-auth-keys.xml to store credentials (change imports, docs,.gitignore) * log4j -> info * add a "." to the first sentence of all the javadocs I noticed. * remove @Public annotations except for some constants (which includes some commitment to maintain them). * move the AbstractFS declarations out of the src/test/resources XML file into core-default.xml for all to use * other IDE-suggested tweaks No actual code changes here; just setting things up better for >1 person editing & testing > ABFS: tune imports & javadocs; stabilise tests > ---------------------------------------------- > > Key: HADOOP-15546 > URL: https://issues.apache.org/jira/browse/HADOOP-15546 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/azure > Affects Versions: HADOOP-15407 > Reporter: Steve Loughran > Assignee: Steve Loughran > Priority: Major > Attachments: HADOOP-15546-001.patch, > HADOOP-15546-HADOOP-15407-001.patch, HADOOP-15546-HADOOP-15407-002.patch, > HADOOP-15546-HADOOP-15407-003.patch, HADOOP-15546-HADOOP-15407-004.patch, > HADOOP-15546-HADOOP-15407-005.patch, HADOOP-15546-HADOOP-15407-006.patch > > > Followup on HADOOP-15540 with some initial review tuning > h2. Tuning > * ordering of imports > * rely on azure-auth-keys.xml to store credentials (change imports, > docs,.gitignore) > * log4j -> info > * add a "." to the first sentence of all the javadocs I noticed. > * remove @Public annotations except for some constants (which includes some > commitment to maintain them). > * move the AbstractFS declarations out of the src/test/resources XML file > into core-default.xml for all to use > * other IDE-suggested tweaks > h2. Testing > Review the tests, move to ContractTestUtil assertions, make more consistent > to contract test setup, and general work to make the tests work well over > slower links, document, etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org