[ 
https://issues.apache.org/jira/browse/HADOOP-7334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039892#comment-13039892
 ] 

Jonathan Eagles commented on HADOOP-7334:
-----------------------------------------

Todd, I wondering if we should remove the '-c' on the first grep. I'm in favor 
of coding style checking. Do you think we have a need to do something like 
checkstyle in the future?

> test-patch should check for hard tabs
> -------------------------------------
>
>                 Key: HADOOP-7334
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7334
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build, test
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>         Attachments: hadoop-7334.txt
>
>
> Our coding guidelines say that hard tabs are disallowed in the Hadoop code, 
> but they sometimes sneak in (there are about 280 in the common codebase at 
> the moment).
> We should run a simple check for this in the test-patch process so it's 
> harder for them to sneak in.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to