[ https://issues.apache.org/jira/browse/HADOOP-7276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040460#comment-13040460 ]
Eli Collins commented on HADOOP-7276: ------------------------------------- I don't see the findbugs warning locally. Don't think a test is needed since this to get the code compiling. {noformat} [exec] [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 system test framework. The patch passed system test framework compile. [exec] {noformat} > Hadoop native builds fail on ARM due to -m32 > -------------------------------------------- > > Key: HADOOP-7276 > URL: https://issues.apache.org/jira/browse/HADOOP-7276 > Project: Hadoop Common > Issue Type: Bug > Components: native > Affects Versions: 0.21.0 > Environment: $ gcc -v > Using built-in specs. > COLLECT_GCC=gcc > COLLECT_LTO_WRAPPER=/usr/lib/arm-linux-gnueabi/gcc/arm-linux-gnueabi/4.5.2/lto-wrapper > Target: arm-linux-gnueabi > Configured with: ../src/configure -v --with-pkgversion='Ubuntu/Linaro > 4.5.2-8ubuntu4' --with-bugurl=file:///usr/share/doc/gcc-4.5/README.Bugs > --enable-languages=c,c++,fortran,objc,obj-c++ --prefix=/usr > --program-suffix=-4.5 --enable-shared --enable-multiarch > --with-multiarch-defaults=arm-linux-gnueabi --enable-linker-build-id > --with-system-zlib --libexecdir=/usr/lib/arm-linux-gnueabi > --without-included-gettext --enable-threads=posix > --with-gxx-include-dir=/usr/include/c++/4.5 > --libdir=/usr/lib/arm-linux-gnueabi --enable-nls --with-sysroot=/ > --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes > --enable-plugin --enable-gold --enable-ld=default --with-plugin-ld=ld.gold > --enable-objc-gc --disable-sjlj-exceptions --with-arch=armv7-a > --with-float=softfp --with-fpu=vfpv3-d16 --with-mode=thumb --disable-werror > --enable-checking=release --build=arm-linux-gnueabi --host=arm-linux-gnueabi > --target=arm-linux-gnueabi > Thread model: posix > gcc version 4.5.2 (Ubuntu/Linaro 4.5.2-8ubuntu4) > $ uname -a > Linux panda0 2.6.38-1002-linaro-omap #3-Ubuntu SMP Fri Apr 15 14:00:54 UTC > 2011 armv7l armv7l armv7l GNU/Linux > Reporter: Trevor Robinson > Assignee: Trevor Robinson > Attachments: hadoop-common-arm.patch > > > The native build fails on machine targets where gcc does not support -m32. > This is any target other than x86, SPARC, RS/6000, or PowerPC, such as ARM. > $ ant -Dcompile.native=true > ... > [exec] make all-am > [exec] make[1]: Entering directory > `/home/trobinson/dev/hadoop-common/build/native/Linux-arm-32' > [exec] /bin/bash ./libtool --tag=CC --mode=compile gcc > -DHAVE_CONFIG_H -I. -I/home/trobinson/dev/hadoop-common/src/native > -I/usr/lib/jvm/java-6-openjdk/include > -I/usr/lib/jvm/java-6-openjdk/include/linux > -I/home/trobinson/dev/hadoop-common/src/native/src > -Isrc/org/apache/hadoop/io/compress/zlib > -Isrc/org/apache/hadoop/security -Isrc/org/apache/hadoop/io/nativeio/ > -g -Wall -fPIC -O2 -m32 -g -O2 -MT ZlibCompressor.lo -MD -MP -MF > .deps/ZlibCompressor.Tpo -c -o ZlibCompressor.lo `test -f > 'src/org/apache/hadoop/io/compress/zlib/ZlibCompressor.c' || echo > '/home/trobinson/dev/hadoop-common/src/native/'`src/org/apache/hadoop/io/compress/zlib/ZlibCompressor.c > [exec] libtool: compile: gcc -DHAVE_CONFIG_H -I. > -I/home/trobinson/dev/hadoop-common/src/native > -I/usr/lib/jvm/java-6-openjdk/include > -I/usr/lib/jvm/java-6-openjdk/include/linux > -I/home/trobinson/dev/hadoop-common/src/native/src > -Isrc/org/apache/hadoop/io/compress/zlib > -Isrc/org/apache/hadoop/security -Isrc/org/apache/hadoop/io/nativeio/ > -g -Wall -fPIC -O2 -m32 -g -O2 -MT ZlibCompressor.lo -MD -MP -MF > .deps/ZlibCompressor.Tpo -c > /home/trobinson/dev/hadoop-common/src/native/src/org/apache/hadoop/io/compress/zlib/ZlibCompressor.c > -fPIC -DPIC -o .libs/ZlibCompressor.o > [exec] make[1]: Leaving directory > `/home/trobinson/dev/hadoop-common/build/native/Linux-arm-32' > [exec] cc1: error: unrecognized command line option "-m32" > [exec] make[1]: *** [ZlibCompressor.lo] Error 1 > [exec] make: *** [all] Error 2 -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira