[ https://issues.apache.org/jira/browse/HADOOP-7341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041891#comment-13041891 ]
Hadoop QA commented on HADOOP-7341: ----------------------------------- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12481006/HADOOP-7341-2.patch against trunk revision 1129905. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/548//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/548//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/548//console This message is automatically generated. > Fix option parsing in CommandFormat > ----------------------------------- > > Key: HADOOP-7341 > URL: https://issues.apache.org/jira/browse/HADOOP-7341 > Project: Hadoop Common > Issue Type: Bug > Components: fs > Affects Versions: 0.23.0 > Reporter: Daryn Sharp > Assignee: Daryn Sharp > Attachments: HADOOP-7341-2.patch, HADOOP-7341.patch > > > CommandFormat currently allows options in any location within the args. This > is not the intended behavior for FsShell commands. Prior to the redesign, > the commands used to expect option processing to stop at the first non-option. > CommandFormat was an existing class prior the redesign, but it was only used > by "count" to find the -q flag. All commands were converted to using this > class, thus inherited the unintended behavior. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira