[ 
https://issues.apache.org/jira/browse/HADOOP-7348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041983#comment-13041983
 ] 

Hadoop QA commented on HADOOP-7348:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12481040/HADOOP-7348.patch
  against trunk revision 1129989.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    -1 core tests.  The patch failed these core unit tests:
                  org.apache.hadoop.cli.TestCLI

    +1 system test framework.  The patch passed system test framework compile.

Test results: 
https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/554//testReport/
Findbugs warnings: 
https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/554//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/554//console

This message is automatically generated.

> Modify the option of FsShell getmerge from [addnl] to [-nl] for more 
> comprehensive
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-7348
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7348
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>    Affects Versions: 0.23.0
>            Reporter: XieXianshan
>            Assignee: XieXianshan
>             Fix For: 0.23.0
>
>         Attachments: HADOOP-7348.patch
>
>
> The [addnl] option of FsShell getmerge should be either "true" or "false",but 
> it is very hard to understand by users, especially  who`s never used this 
> option before. 
> So,the [addnl] option should be changed to [-nl] for more comprehensive.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to