[ https://issues.apache.org/jira/browse/HADOOP-15739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16619341#comment-16619341 ]
Steve Loughran commented on HADOOP-15739: ----------------------------------------- Looking at the patch + 1 to removing guice; just commented it out and rebuilt and verifies that it's not needed. (it comes in at test time via hadoop-mapreduce anyway) = 0 to explicitly declaring all the transitive cruft coming in from hadoop-common at provided. -1 to the explicit declarations of transitive stuff coming in from hadoop-common as compile why? the cloud connectors now all say "hadoop-common is provided", along with all the transitive dependencies; hadoop-cloud-storage tries to be even leaner. I don't want to force downstream projects to remain stuck in the problem of having to explicitly exclude every compile-time dependency of a cloud connector; all they should need to do, at worst, is exclude hadoop-common and get everything that it pulls in automatically stripped off. Yes, they will need to declare hadoop-common somewhere else, but that becomes a single place to play the exclude game about seemingly random artifacts. jackson is of course trouble here. Being explicit and letting downstream deal with it is as good as you can get, I suspect. > ABFS: remove unused maven dependencies and add used undeclared dependencies > --------------------------------------------------------------------------- > > Key: HADOOP-15739 > URL: https://issues.apache.org/jira/browse/HADOOP-15739 > Project: Hadoop Common > Issue Type: Sub-task > Components: build, fs/azure > Affects Versions: HADOOP-15407 > Reporter: Da Zhou > Assignee: Da Zhou > Priority: Major > Attachments: HADOOP-15739-HADOOP-15407-001.patch, > HADOOP-15739-HADOOP-15407-002.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org