[ 
https://issues.apache.org/jira/browse/HADOOP-15566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16623548#comment-16623548
 ] 

Carlos Alberto Cortez commented on HADOOP-15566:
------------------------------------------------

Hi all,

I went ahead and did a Proof-Of-Concept migration from HTrace to OpenTracing 
(using Zipkin as the backend). You can inspect (and play with the code) here: 
[https://github.com/apache/hadoop/compare/trunk...carlosalberto:ot_initial_integration]

Some notes:

1. It creates by default a Tracer instance based on Zipkin running in localhost 
(for simplicity purposes).
2. It uses the notion of a GlobalTracer so create and register and use the 
Tracer from a single place.
3. As Wei-Chiu mentioned, it needed some small extra work to pass around the 
parent-child relationship (which is done trough `SpanId` in HTrace, and 
`SpanContext` in OpenTracing).
4. Added a new SpanContext field in the clases using protobuf to pass trace 
info.

As mentioned, this is a POC, but hope this can throw light into this (and I'm 
happy to answer questions or contribute with this as an actual migration ;) )

> Remove HTrace support
> ---------------------
>
>                 Key: HADOOP-15566
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15566
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 3.1.0
>            Reporter: Todd Lipcon
>            Priority: Major
>              Labels: security
>         Attachments: Screen Shot 2018-06-29 at 11.59.16 AM.png, 
> ss-trace-s3a.png
>
>
> The HTrace incubator project has voted to retire itself and won't be making 
> further releases. The Hadoop project currently has various hooks with HTrace. 
> It seems in some cases (eg HDFS-13702) these hooks have had measurable 
> performance overhead. Given these two factors, I think we should consider 
> removing the HTrace integration. If there is someone willing to do the work, 
> replacing it with OpenTracing might be a better choice since there is an 
> active community.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to