[ 
https://issues.apache.org/jira/browse/HADOOP-15676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646865#comment-16646865
 ] 

Szilard Nemeth commented on HADOOP-15676:
-----------------------------------------

Hi [~xiaochen]!
Thanks for the explanation, it is indeed better to just let the exception 
thrown out from the method so we have more information in the logs.
I'm with you when you mentioned improving the code if we touch it, since this 
is a cleanup jira, I think changing the things you mentioned makes sense.
See the new patch with the fixes!
Thanks!

> Cleanup TestSSLHttpServer
> -------------------------
>
>                 Key: HADOOP-15676
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15676
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: common
>    Affects Versions: 2.6.0
>            Reporter: Szilard Nemeth
>            Assignee: Szilard Nemeth
>            Priority: Minor
>         Attachments: HADOOP-15676.001.patch, HADOOP-15676.002.patch, 
> HADOOP-15676.003.patch, HADOOP-15676.004.patch, HADOOP-15676.005.patch
>
>
> This issue will fix: 
> * Several typos in this class
> * Code is not very well readable in some of the places.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to