[
https://issues.apache.org/jira/browse/HADOOP-11100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648244#comment-16648244
]
Xiao Chen commented on HADOOP-11100:
------------------------------------
Thanks [~adam.antal] for the good work here, and [~knanasi] for the review.
Overall LGTM. 2 additional comments:
* We should add a core-default.xml entry for the new config.
\{{TestCommonConfigurationFields}} usually catches this, but ftp is kind of a
special case so missed here. Once the config is added to core-default.xml,
you'd need to update \{{TestCommonConfigurationFields}} to make the test pass.
* Adding a timeout is a nice improvement. Strictly speaking, setting the
default changes the current behavior. In general we try not to change the
default behavior, for compatibility reasons. Only when something is obviously
wrong, to the point which we consider it a bug, would we change the default
behavior. I'd suggest we set the default to 0 here, to retain existing behavior
(since FTPFileSystem has been there for a long time and is marked as Public
Stable).
> Support to configure ftpClient.setControlKeepAliveTimeout
> -----------------------------------------------------------
>
> Key: HADOOP-11100
> URL: https://issues.apache.org/jira/browse/HADOOP-11100
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 2.3.0
> Reporter: Krishnamoorthy Dharmalingam
> Assignee: Adam Antal
> Priority: Minor
> Attachments: HADOOP-11100.002.patch, HADOOP-11100.003.patch,
> HDFS-11000.001.patch
>
>
> In FTPFilesystem or Configuration, timeout is not possible to configure.
> It is very straight forward to configure, in FTPFilesystem.connect() method.
> ftpClient.setControlKeepAliveTimeout
> Like
> private FTPClient connect() throws IOException {
> ...
> String timeout = conf.get("fs.ftp.timeout." + host);
> ...
> ftpClient.setControlKeepAliveTimeout(new Integer(300));
> ....
> }
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
