[ 
https://issues.apache.org/jira/browse/HADOOP-15856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660153#comment-16660153
 ] 

Vinayakumar B commented on HADOOP-15856:
----------------------------------------

You are right [~ayushtkn].

This will fix {{org.apache.hadoop.fs.TestHdfsNativeCodeLoader}}

The reason for failure of {{org.apache.hadoop.fs.TestHdfsNativeCodeLoader}} is 
as follows.
1. Yetus will run a full build (mvn clean install) on root dir after patch is 
applied WIHTOUT *-Pnative*
2. Just before running HDFS Unit tests it runs the dependent modules WITH 
*-Pnative" enabled. i.e Yetus will build hadoop-common module. Note that, this 
time it just runs the incremental build, not the clean build. i.e. only {{mvn 
install -Pnative -DskipTests ..}} without clean.
3. Before HADOOP-15767, Required JNI headers were created by executing 
{{javah}} command during "-Pnative" profile itself. But after HADOOP-15767, 
{{javah}} command invocation is removed, and JNI header files supposed to be 
generated during compilation of all classes.
4. After HADOOP-15767. JNI headers will get generated only if *-Pnative* is 
enabled. In above Step#2, since the compilation is incremental, even with 
*-Pnative*, no JNI headers were generated and Native compilation failed. Also 
Yetus failed to detect this failure and went ahead with unit test execution 
without any native files.

With this patch, To generate JNI header files, there is no need of enabling any 
profile. JNI header files will always gets generated.

> Trunk build fails to compile native on Windows
> ----------------------------------------------
>
>                 Key: HADOOP-15856
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15856
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: native
>            Reporter: Vinayakumar B
>            Assignee: Vinayakumar B
>            Priority: Blocker
>         Attachments: HADOOP-15856-01.patch
>
>
> After removal of {{javah}} dependency in HADOOP-15767
> Trunk build fails with unable to find JNI headers.
> HADOOP-15767 fixed javah isssue with JDK10 only for linux builds.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to