[ https://issues.apache.org/jira/browse/HADOOP-15836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660675#comment-16660675 ]
Jason Lowe commented on HADOOP-15836: ------------------------------------- Yes, this should be changed back to HashSet. I'm all for making the unit tests more resilient to different implementations, but I don't see why we would want to choose TreeSet over HashSet here. The API never said anything about ordering, and I don't think we should start ordering it just to make some lazy unit tests happy. Changing the implementation in a way that does not fix a bug in the implementation just adds risk. I propose we revert this change and put up another patch if there's still things worth changing without the TreeSet modification in place (like maybe the unmodifiable set change). > Review of AccessControlList > --------------------------- > > Key: HADOOP-15836 > URL: https://issues.apache.org/jira/browse/HADOOP-15836 > Project: Hadoop Common > Issue Type: Improvement > Components: common, security > Affects Versions: 3.2.0 > Reporter: BELUGA BEHR > Assignee: BELUGA BEHR > Priority: Minor > Fix For: 3.3.0 > > Attachments: HADOOP-15836.1.patch > > > * Improve unit tests (expected / actual were backwards) > * Unit test expected elements to be in order but the class's return > Collections were unordered > * Formatting cleanup > * Removed superfluous white space > * Remove use of LinkedList > * Removed superfluous code > * Use {{unmodifiable}} Collections where JavaDoc states that caller must not > manipulate the data structure -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org