[
https://issues.apache.org/jira/browse/HADOOP-15919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690577#comment-16690577
]
Weiwei Yang commented on HADOOP-15919:
--------------------------------------
Hi [~wujinhu]
I took a look at the patch, overall it looks good. A few nits
*TestOSS.java*
Could u replace
{code:java}
public final Timeout testTimeout = new Timeout(90000);
{code}
with @Test (timeout = 90000L)? As {{Timeout}} is a deprecated class. And may I
know why this needs a 90s timeout?
*TestOSSFileContext.java*
This is an empty class
*Index.md*
The description for {{fs.AbstractFileSystem.oss.impl}} is not very informative,
as this is going to be a main user doc, can you add more information there?
*AliyunOSSTestUtils.java*
most of code in {{createTestFileSystem}} and {{createTestFileContext}} are
same, can we reuse them by seperating to a private function?
*AliyunOSSFileSystemStore*
Not sure why you need to remove
statistics.incrementBytesWritten(file.length());
it seems not related to the motivation of this jira, is it?
Thanks
> AliyunOSS: Enable Yarn to use OSS
> ---------------------------------
>
> Key: HADOOP-15919
> URL: https://issues.apache.org/jira/browse/HADOOP-15919
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs/oss
> Affects Versions: 2.10.0, 2.9.1, 3.2.0, 3.1.1, 3.0.3
> Reporter: wujinhu
> Assignee: wujinhu
> Priority: Major
> Attachments: HADOOP-15919.001.patch, HADOOP-15919.002.patch
>
>
> Uses DelegateToFileSystem to expose AliyunOSSFileSystem as an
> AbstractFileSystem
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
