[ https://issues.apache.org/jira/browse/HADOOP-15909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16699139#comment-16699139 ]
Kuhu Shukla commented on HADOOP-15909: -------------------------------------- Pinging [~daryn]/[~kihwal] for some review comments. Thanks a lot! > KeyProvider class should implement Closeable > -------------------------------------------- > > Key: HADOOP-15909 > URL: https://issues.apache.org/jira/browse/HADOOP-15909 > Project: Hadoop Common > Issue Type: Improvement > Components: kms > Affects Versions: 3.0.3, 2.8.5 > Reporter: Kuhu Shukla > Assignee: Kuhu Shukla > Priority: Major > Attachments: HADOOP-15909.001.patch > > > KeyProviders and the extensions have close() methods. The classes should > implement Closeable that will allow try-with-resources to work and help catch > original exceptions instead of finally blocks and exception masking that > follows that. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org