[ https://issues.apache.org/jira/browse/HADOOP-15950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16705369#comment-16705369 ]
Wei-Chiu Chuang commented on HADOOP-15950: ------------------------------------------ Looks good to me. I think it's safe to ignore the javac warning "LdapCtxFactory is internal proprietary API and may be removed in a future release". The use of of LdapCtxFactory is mentioned in Oracle JDK's doc page. Not sure if there are other ways not to use it. Optional, but IMO It would be even better if the following log message records the ldap server URL (currentLdapUrl): {code} LOG.warn("Failed to get groups for user {} (attempt={}/{}). " + "Exception: ", user, attempt, numAttempts, e); {code} > Failover for LdapGroupsMapping > ------------------------------ > > Key: HADOOP-15950 > URL: https://issues.apache.org/jira/browse/HADOOP-15950 > Project: Hadoop Common > Issue Type: New Feature > Components: common, security > Reporter: Lukas Majercak > Assignee: Lukas Majercak > Priority: Major > Attachments: HADOOP-15950.001.patch, HADOOP-15950.002.patch, > HADOOP-15950.003.patch, HADOOP-15950.004.patch, HADOOP-15950.005.patch, > HADOOP-15950.006.patch, HADOOP-15950.007.patch, HADOOP-15950.008.patch > > > Currently, LdapGroupsMapping supports only a single ldap server url, this can > obviously cause issues if the ldap instance goes down. This JIRA attempts to > improve this by allowing users to list multiple ldap server urls, and > performing a failover if we detect any issues. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org