[
https://issues.apache.org/jira/browse/HADOOP-15988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16715805#comment-16715805
]
Sean Mackrory commented on HADOOP-15988:
----------------------------------------
Good stuff. A few nits:
* Can you clean up the checkstyle issues that were raised?
* Most of the code between the 2 tests is shared. Can we refactor that into a
single test that just tests the same sequence with a different auth value and
outcome? If that turns out to be messy for some reason it's not a deal breaker,
but worth a couple of minutes if that's all it takes.
+1 otherwise.
> Should be able to set empty directory flag to TRUE in
> DynamoDBMetadataStore#innerGet when using authoritative directory listings
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-15988
> URL: https://issues.apache.org/jira/browse/HADOOP-15988
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.1.0
> Reporter: Gabor Bota
> Assignee: Gabor Bota
> Priority: Major
> Attachments: HADOOP-15988.001.patch
>
>
> We have the following comment and implementation in DynamoDBMetadataStore:
> {noformat}
> // When this class has support for authoritative
> // (fully-cached) directory listings, we may also be able to answer
> // TRUE here. Until then, we don't know if we have full listing or
> // not, thus the UNKNOWN here:
> meta.setIsEmptyDirectory(
> hasChildren ? Tristate.FALSE : Tristate.UNKNOWN);
> {noformat}
> We have authoritative listings now in dynamo since HADOOP-15621, so we should
> resolve this comment, implement the solution and test it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
