[ 
https://issues.apache.org/jira/browse/HADOOP-15860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16720899#comment-16720899
 ] 

Sean Mackrory commented on HADOOP-15860:
----------------------------------------

Thanks for the patch [~shwetayakkali]. For the most part it looks good, but I 
think we need to consider the trailing slash a little harder. A destination 
path absolutely can end in a trailing slash (e.g. mv /some-file 
/some-existing-directory/). On the other hand, I'm actually not sure how or if 
one can create a file that ends with a trailing slash. I suspect that the Path 
class already handles the trailing slash as much as we need it to, and we 
should just check for trailing periods. But we should dig and confirm that the 
edge cases here are working correctly.

> ABFS: Throw IllegalArgumentException when Directory/File name ends with a 
> period(.)
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-15860
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15860
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/adl
>    Affects Versions: 3.2.0
>            Reporter: Sean Mackrory
>            Assignee: Shweta
>            Priority: Major
>         Attachments: HADOOP-15860.001.patch, trailing-periods.patch
>
>
> If you create a directory with a trailing period (e.g. '/test.') the period 
> is silently dropped, and will be listed as simply '/test'. '/test.test' 
> appears to work just fine.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to