[ 
https://issues.apache.org/jira/browse/HADOOP-16030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735462#comment-16735462
 ] 

wujinhu commented on HADOOP-16030:
----------------------------------

This patch includes two changes:
{code:java}
-        store.completeMultipartUpload(key, uploadId, partETags);
+        store.completeMultipartUpload(key, uploadId,
+            new ArrayList<>(partETags));
       }
{code}
{code:java}
-  public static CredentialsProvider getCredentialsProvider(Configuration conf)
-      throws IOException {
+  public static CredentialsProvider getCredentialsProvider(
+      URI uri, Configuration conf) throws IOException {
     CredentialsProvider credentials;
 
     String className = conf.getTrimmed(CREDENTIALS_PROVIDER_KEY);
@@ -117,7 +119,7 @@ public static CredentialsProvider 
getCredentialsProvider(Configuration conf)
         try {
           credentials =
               (CredentialsProvider)credClass.getDeclaredConstructor(
-                  Configuration.class).newInstance(conf);
+                  URI.class, Configuration.class).newInstance(uri, conf)
{code}
First one:

Hadoop depends on guava 11.0.2, and hadoop-aliyun uses *allAsList* interface 
which returns mutable list. However, when we run hive jobs on hadoop, it will 
throw ConcurrentModificationException because hive contains higher guava 
version and its *allAsList* interface returns immutable list.

 

Second one:

Stabilise the constructor of CredentialsProvider so that other developers can 
have their own implementations.

> AliyunOSS: bring fixes back from HADOOP-15671
> ---------------------------------------------
>
>                 Key: HADOOP-16030
>                 URL: https://issues.apache.org/jira/browse/HADOOP-16030
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs/oss
>    Affects Versions: 3.2.0, 3.1.1, 2.9.2, 3.0.3, 3.3.0
>            Reporter: wujinhu
>            Assignee: wujinhu
>            Priority: Blocker
>         Attachments: HADOOP-16030.001.patch
>
>
> https://issues.apache.org/jira/browse/HADOOP-15992 reverted 2 patches, 
> however, those two patches contain bug fixes, we should bring them back



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to