[
https://issues.apache.org/jira/browse/HADOOP-16097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16765744#comment-16765744
]
Yiqun Lin commented on HADOOP-16097:
------------------------------------
Thanks for addressing the comments, [~xkrogen]! The patch looks great now.
{quote}The priority level computation for the users is started from low
priority levels since they will be most common.
{quote}
This sentence is from the comment in
{{DecayRpcScheduler#computePriorityLevel}}. I just want let users know the
computation for the priority level. But it's ok to mention this or not. Current
description is enough I think.
Rendered the doc in my local, the imgae cannot be rendered well,
Can we update {{(../resources/images/faircallqueue-overview.png)}} to
{{(./images/faircallqueue-overview.png)}}? For the hadoop site page, the latter
should be the right path, the former only makes sense for the github page.
BTW, [~xkrogen], can you attach a screen shot of the rendered page once this
addressed?
Follow steps:
* cd hadoop-common-project/hadoop-common
* run mvn site:site
* open the page
hadoop-common-project/hadoop-common/target/site/FairCallQueue.html
> Provide proper documentation for FairCallQueue
> ----------------------------------------------
>
> Key: HADOOP-16097
> URL: https://issues.apache.org/jira/browse/HADOOP-16097
> Project: Hadoop Common
> Issue Type: Improvement
> Components: documentation, ipc
> Reporter: Erik Krogen
> Assignee: Erik Krogen
> Priority: Major
> Attachments: HADOOP-16097.000.patch, HADOOP-16097.001.patch,
> faircallqueue-overview.png
>
>
> FairCallQueue, added in HADOOP-10282, doesn't seem to be well-documented
> anywhere. Let's add in a new documentation for it and related components.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
