ajayydv commented on a change in pull request #587: HDDS-1245. OM delegation
expiration time should use Time.now instead …
URL: https://github.com/apache/hadoop/pull/587#discussion_r264315721
##########
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/security/OzoneDelegationTokenSecretManager.java
##########
@@ -158,12 +158,12 @@ private void addToTokenStore(OzoneTokenIdentifier
identifier, byte[] password)
*/
private void updateIdentifierDetails(OzoneTokenIdentifier identifier) {
int sequenceNum;
- long now = Time.monotonicNow();
+ long now = Time.now();
sequenceNum = incrementDelegationTokenSeqNum();
identifier.setIssueDate(now);
identifier.setMasterKeyId(getCurrentKey().getKeyId());
identifier.setSequenceNumber(sequenceNum);
- identifier.setMaxDate(Time.monotonicNow() + getTokenMaxLifetime());
+ identifier.setMaxDate(Time.now() + getTokenMaxLifetime());
Review comment:
shall we use already initialized now variable here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
