xiaoyuyao commented on a change in pull request #627: HDDS-1299. Support TokenIssuer interface for running jobs with OzoneFileSystem. URL: https://github.com/apache/hadoop/pull/627#discussion_r268356876
########## File path: hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/OzoneClientAdapterImpl.java ########## @@ -289,7 +291,7 @@ public boolean hasNextKey(String key) { @Override public Token<OzoneTokenIdentifier> getDelegationToken(String renewer) throws IOException { - if (!securityEnabled) { + if (!securityEnabled || renewer == null) { Review comment: Only block token does not require renew, but it will not be retrieved from here. So I think we will not allow empty/null renewer like HDFS. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org