[
https://issues.apache.org/jira/browse/HADOOP-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058565#comment-13058565
]
Hadoop QA commented on HADOOP-7437:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12484868/HADOOP-7437.patch
against trunk revision 1141638.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/689//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HADOOP-Build/689//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/689//console
This message is automatically generated.
> IOUtils.copybytes will suppress the stream closure exceptions.
> ---------------------------------------------------------------
>
> Key: HADOOP-7437
> URL: https://issues.apache.org/jira/browse/HADOOP-7437
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7437.patch
>
>
> {code}
> public static void copyBytes(InputStream in, OutputStream out, long count,
> boolean close) throws IOException {
> byte buf[] = new byte[4096];
> long bytesRemaining = count;
> int bytesRead;
> try {
> .............
> .............
> } finally {
> if (close) {
> closeStream(out);
> closeStream(in);
> }
> }
> }
> {code}
> Here if any exception in closing the stream, it will get suppressed here.
> So, better to follow the stream closure pattern as HADOOP-7194.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
