[ 
https://issues.apache.org/jira/browse/HADOOP-16208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Loughran updated HADOOP-16208:
------------------------------------
       Resolution: Fixed
    Fix Version/s: 3.1.3
                   3.2.1
           Status: Resolved  (was: Patch Available)

+1, 
committed to branches 3.1, 3.2 and trunk

> Do Not Log InterruptedException in Client
> -----------------------------------------
>
>                 Key: HADOOP-16208
>                 URL: https://issues.apache.org/jira/browse/HADOOP-16208
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: common
>    Affects Versions: 3.2.0
>            Reporter: David Mollitor
>            Assignee: David Mollitor
>            Priority: Minor
>             Fix For: 3.2.1, 3.1.3
>
>         Attachments: HADOOP-16208.1.patch, HADOOP-16208.2.patch, 
> HADOOP-16208.3.patch
>
>
> {code:java}
>        } catch (InterruptedException e) {
>         Thread.currentThread().interrupt();
>         LOG.warn("interrupted waiting to send rpc request to server", e);
>         throw new IOException(e);
>       }
> {code}
> https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java#L1450
> I'm working on a project that uses an {{ExecutorService}} to launch a bunch 
> of threads.  Each thread spins up an HDFS client connection.  At any point in 
> time, the program can terminate and call {{ExecutorService#shutdownNow()}} to 
> forcibly close vis-à-vis {{Thread#interrupt()}}.  At that point, I get a 
> cascade of logging from the above code and there's no easy to way to turn it 
> off.
> "Log and throw" is generally frowned upon, just throw the {{Exception}} and 
> move on.
> https://community.oracle.com/docs/DOC-983543#logAndThrow



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to