sahilTakiar commented on a change in pull request #597: HDFS-3246: pRead
equivalent for direct read path
URL: https://github.com/apache/hadoop/pull/597#discussion_r273753051
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfs/hdfs.c
##########
@@ -985,6 +1011,49 @@ int hdfsStreamBuilderSetDefaultBlockSize(struct
hdfsStreamBuilder *bld,
return 0;
}
+static int hdfsHasStreamCapability(jobject jFile,
+ const char *capability) {
+ int ret = 0;
+ jthrowable jthr = NULL;
+ jvalue jVal;
+ jstring jCapabilityString = NULL;
+
+ /* Get the JNIEnv* corresponding to current thread */
+ JNIEnv* env = getJNIEnv();
+ if (env == NULL) {
+ errno = EINTERNAL;
+ return 0;
+ }
+
+ jthr = newJavaStr(env, capability, &jCapabilityString);
+ if (jthr) {
+ ret = printExceptionAndFree(env, jthr, PRINT_EXC_ALL,
+ "hdfsHasStreamCapability(%s): newJavaStr", capability);
+ goto done;
+ }
+ jthr = invokeMethod(env, &jVal, INSTANCE, jFile,
+ JC_FS_DATA_INPUT_STREAM, "hasCapability", "(Ljava/lang/String;)Z",
+ jCapabilityString);
+ if (jthr) {
+ ret = printExceptionAndFree(env, jthr, PRINT_EXC_ALL,
+ "hdfsHasStreamCapability(%s): FSDataInputStream#hasCapability",
+ capability);
+ goto done;
+ }
+
+done:
+ destroyLocalReference(env, jthr);
+ destroyLocalReference(env, jCapabilityString);
+ if (ret) {
+ errno = ret;
+ return 0;
Review comment:
Yeah. I think the reason for setting `errno` is that all the other methods
set this to indicate that an exception occurred while the method was run. So if
`ret` is true and `errno` needs to be set, then the method has to return with
some value, right? Returning `false` seemed more reasonable than returning
`true`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
