steveloughran commented on a change in pull request #716: HADOOP-16205 
Backporting ABFS driver from trunk to branch 2.0
URL: https://github.com/apache/hadoop/pull/716#discussion_r275091519
 
 

 ##########
 File path: 
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractAppendTest.java
 ##########
 @@ -117,13 +122,9 @@ public void testBuilderAppendToExistingFile() throws 
Throwable {
   @Test
   public void testAppendMissingTarget() throws Throwable {
     try {
-      FSDataOutputStream out = getFileSystem().append(target);
-      //got here: trouble
-      out.close();
-      fail("expected a failure");
-    } catch (Exception e) {
-      //expected
-      handleExpectedException(e);
+      getFileSystem().append(target).close();
+    } catch (Exception ex) {
+      handleExpectedException(ex);
 
 Review comment:
   again, test is no longer a test of the behavior of any filesystem

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to